Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ability to pass in iam permissions boundary #110

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

joelmccoy
Copy link

@joelmccoy joelmccoy commented Jan 14, 2025

Description of the change

Added the ability to pass in an IAM permissions boundary to this module. I already got an change merged in here for the autoscaler submodule. This is a common practice in AWS to have a permissions boundary assigned to all your IAM roles.

Additionally I pinned the ec2-workerpool-autoscaler module reference to the latest release (as it was pulling main which is not ideal). edit: I now realize this can be passed in as a variable.

Type of change

  • Bug fix (non-breaking change that fixes an issue);
  • New feature (non-breaking change that adds functionality);
  • Breaking change (fix or feature that would cause existing functionality to not work as expected);
  • Documentation (a documentation or example fix not affecting the infrastructure managed by this module);

Checklists

Development

  • All necessary variables have been defined, with defaults if applicable;
  • The code is formatted properly;

Code review

  • The module version is bumped accordingly;
  • Spacelift tests are passing;
  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached;
  • This pull request is no longer marked as "draft";
  • Reviewers have been assigned;
  • Changes have been reviewed by at least one other engineer;

@joelmccoy joelmccoy requested a review from a team as a code owner January 14, 2025 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants