review

atxsdata/data.go

@@ -2,8 +2,7 @@ package atxsdata
 
 import (
 	"sync"
-
-	"go.uber.org/atomic"
+	"sync/atomic"
 
 	"github.com/spacemeshos/go-spacemesh/common/types"
 )
@@ -74,15 +73,16 @@ func (d *Data) IsEvicted(epoch types.EpochID) bool {
 // OnEpoch is a notification for cache to evict epochs that are not useful
 // to keep in memory.
 func (d *Data) OnEpoch(applied types.EpochID) {
-	d.mu.Lock()
-	defer d.mu.Unlock()
 	if applied < d.capacity {
 		return
 	}
 	evict := applied - d.capacity
 	if d.IsEvicted(evict) {
 		return
 	}
+
+	d.mu.Lock()
+	defer d.mu.Unlock()
 	if d.evicted.Load() < evict.Uint32() {
 		d.evicted.Store(evict.Uint32())
 	}
@@ -102,11 +102,11 @@ func (d *Data) Add(
 	nonce types.VRFPostIndex,
 	malicious bool,
 ) {
-	d.mu.Lock()
-	defer d.mu.Unlock()
 	if d.IsEvicted(epoch) {
 		return
 	}
+	d.mu.Lock()
+	defer d.mu.Unlock()
 	ecache, exists := d.epochs[epoch]
 	if !exists {
 		ecache = epochCache{

atxsdata/warmup.go

@@ -54,13 +54,3 @@ func Warmup(db sql.Executor, cache *Data) error {
 	}
 	return ierr
 }
-
-func ToATXData(atx *types.ActivationTxHeader, nonce types.VRFPostIndex, malicious bool) *ATX {
-	return &ATX{
-		Weight:     atx.GetWeight(),
-		BaseHeight: atx.BaseTickHeight,
-		Height:     atx.TickHeight(),
-		Nonce:      nonce,
-		Malicious:  malicious,
-	}
-}