Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop lru cache (used for atxs and to track malfeasant identities) #5039

Open
dshulyak opened this issue Sep 20, 2023 · 0 comments
Open

drop lru cache (used for atxs and to track malfeasant identities) #5039

dshulyak opened this issue Sep 20, 2023 · 0 comments

Comments

@dshulyak
Copy link
Contributor

once #5013 is merged we don't need to use lru cache in consensus layer anymore.

the process for removing it as follows:

  • in consensus (tortoise, beacon, certificate, hare3) start using cache with all activation data
    tortoise should also support slowpath for old ballots/atxs (2-3 epochs before)
  • in atxs use sql storage directly for validation, all queries must be simple and hit existing indexes (smesher, epoch index and atx id primary index)
  • in sync and api use direct access to sql
@dshulyak dshulyak moved this to 🔖 Next in Dev team kanban Sep 20, 2023
@dshulyak dshulyak changed the title deprecate lru cache drop lru cache (used for atxs and to track malfeasent identeties) Sep 20, 2023
@dshulyak dshulyak changed the title drop lru cache (used for atxs and to track malfeasent identeties) drop lru cache (used for atxs and to track malfeasent identities) Sep 20, 2023
@dshulyak dshulyak moved this from 🔖 Next to 📋 Backlog in Dev team kanban Sep 21, 2023
@dshulyak dshulyak moved this from 📋 Backlog to 🔖 Next in Dev team kanban Oct 17, 2023
@dshulyak dshulyak self-assigned this Oct 17, 2023
@dshulyak dshulyak moved this from 🔖 Next to 📋 Backlog in Dev team kanban Oct 17, 2023
@dshulyak dshulyak removed their assignment Oct 17, 2023
@lrettig lrettig changed the title drop lru cache (used for atxs and to track malfeasent identities) drop lru cache (used for atxs and to track malfeasant identities) Oct 17, 2023
@dshulyak dshulyak self-assigned this Nov 13, 2023
@dshulyak dshulyak moved this from 📋 Backlog to 🏗 Doing in Dev team kanban Nov 19, 2023
spacemesh-bors bot pushed a commit that referenced this issue Feb 6, 2024
related: #5039

it wasn't using any methods that are caching state, so it is a simple cleanup.
spacemesh-bors bot pushed a commit that referenced this issue Feb 6, 2024
related: #5039

it wasn't using any methods that are caching state, so it is a simple cleanup.
@pigmej pigmej moved this from 🏗 Doing to 📋 Backlog in Dev team kanban Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 📋 Backlog
Development

No branches or pull requests

1 participant