Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - disable beacon protocol in epoch 7 #5083

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - disable beacon protocol in epoch 7 #5083

wants to merge 2 commits into from

Conversation

countvonzero
Copy link
Contributor

@countvonzero countvonzero commented Sep 26, 2023 •
edited
Loading

Motivation

disable beacon protocol until #4989 and #4583 are fixed

Changes

set RoundsNumber == 0 to disable beacon protocol and not listen to beacon gossip

TODO

  • Update changelog as needed
  • test on devnet-406-short

@codecov
Copy link

codecov bot commented Sep 26, 2023 •
edited
Loading

Codecov Report

Merging #5083 (3a8605c) into develop (878ed5d) will increase coverage by 0.0%.
Report is 8 commits behind head on develop.
The diff coverage is 60.0%.

@@           Coverage Diff           @@
##           develop   #5083   +/-   ##
=======================================
  Coverage     77.0%   77.1%           
=======================================
  Files          257     257           
  Lines        30278   30340   +62     
=======================================
+ Hits         23328   23393   +65     
+ Misses        5423    5416    -7     
- Partials      1527    1531    +4
Files Coverage Δ
config/mainnet.go 96.2% <100.0%> (+0.4%) ⬆️
node/node.go 63.7% <100.0%> (+0.1%) ⬆️
beacon/beacon.go 79.2% <20.0%> (+0.8%) ⬆️

... and 8 files with indirect coverage changes

@countvonzero
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Sep 26, 2023
@bors
Try #5083:
2ebbd2d
@bors
Copy link

bors bot commented Sep 26, 2023

try

Build failed:

@countvonzero
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Sep 26, 2023
@bors
Try #5083:
03f8ad7
@bors
Copy link

bors bot commented Sep 26, 2023

try

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

dshulyak
dshulyak approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@dshulyak dshulyak left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the main reason why we disable it is this #4989 . we need to find a way to run it. i am not even sure that idea with simple jitter will be sufficient

#4583 is a follow to make that change succeed

@countvonzero
Copy link
Contributor Author

bors merge

bors bot pushed a commit that referenced this pull request Sep 27, 2023
@countvonzero
disable beacon protocol in epoch 7 (#5083)
ba67e60 
## Motivation
disable beacon protocol until #4989 and #4583 are fixed

## Changes
set RoundsNumber == 0 to disable beacon protocol and not listen to beacon gossip

## TODO
- [x] Update [changelog](../CHANGELOG.md) as needed
- [x] test on devnet-406-short
@bors
Copy link

bors bot commented Sep 27, 2023

Build failed:

@countvonzero
Copy link
Contributor Author

bors merge

bors bot pushed a commit that referenced this pull request Sep 27, 2023
@countvonzero
disable beacon protocol in epoch 7 (#5083)
a1c74a0 
## Motivation
disable beacon protocol until #4989 and #4583 are fixed

## Changes
set RoundsNumber == 0 to disable beacon protocol and not listen to beacon gossip

## TODO
- [x] Update [changelog](../CHANGELOG.md) as needed
- [x] test on devnet-406-short
@bors
Copy link

bors bot commented Sep 27, 2023

Pull request successfully merged into develop.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title disable beacon protocol in epoch 7 [Merged by Bors] - disable beacon protocol in epoch 7 Sep 27, 2023
@bors bors bot closed this Sep 27, 2023
@bors bors bot deleted the disable-beacon branch September 27, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fasmat fasmat fasmat approved these changes

@dshulyak dshulyak dshulyak approved these changes

@poszu poszu Awaiting requested review from poszu poszu is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@countvonzero @dshulyak @fasmat