[Merged by Bors] - sync: prioritize peers with higher success rate and low latency #5143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #5143 +/- ##
==========================================
+ Coverage 0 77.7% +77.7%
==========================================
Files 0 259 +259
Lines 0 30495 +30495
==========================================
+ Hits 0 23704 +23704
- Misses 0 5299 +5299
- Partials 0 1492 +1492
|
dshulyak
changed the title
|
poszu
approved these changes
Oct 12, 2023
|
bors try |
tryBuild failed: |
|
@poszu i added benchmark. below is SelectBest(10) from 10000 total. how did you get 3 ms?
|
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Oct 13, 2023
closes: #5127 #5036 peers that are overwhelmed or generally will not be used for requests. there are two criteria used to select good peer: - request success rate . success rates within 0.1 (10%) of each other are treated as equal, and in such case we will use latency - latency. hs/1 protocol used to track latency, as it is the most used protocol and objects served in this protocol are of the same size with several exceptions (active sets, list of malfeasence proofs). related: #4977 limits number of peers to request data for atxs. previously we were requesting data from all peers atleast once. synced data 2 times in 90m, previous attempt on my computer was 1 week ago and took 12h
|
Build failed: |
|
bors merge |
|
bors cancel |
|
Canceled. |
dshulyak
force-pushed
the
sync/priotize-fast
branch
from
b0c679d to
dcca7de
Compare
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Oct 13, 2023
closes: #5127 #5036 peers that are overwhelmed or generally will not be used for requests. there are two criteria used to select good peer: - request success rate . success rates within 0.1 (10%) of each other are treated as equal, and in such case we will use latency - latency. hs/1 protocol used to track latency, as it is the most used protocol and objects served in this protocol are of the same size with several exceptions (active sets, list of malfeasence proofs). related: #4977 limits number of peers to request data for atxs. previously we were requesting data from all peers atleast once. synced data 2 times in 90m, previous attempt on my computer was 1 week ago and took 12h
|
Pull request successfully merged into develop. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page.
|
bors
bot
changed the title
I'm sorry, my bad - I can't do the math 🤦 it was 3µs. |
dshulyak
added a commit
to dshulyak/go-spacemesh
that referenced
this pull request
Oct 13, 2023
…emeshos#5143) closes: spacemeshos#5127 spacemeshos#5036 peers that are overwhelmed or generally will not be used for requests. there are two criteria used to select good peer: - request success rate . success rates within 0.1 (10%) of each other are treated as equal, and in such case we will use latency - latency. hs/1 protocol used to track latency, as it is the most used protocol and objects served in this protocol are of the same size with several exceptions (active sets, list of malfeasence proofs). related: spacemeshos#4977 limits number of peers to request data for atxs. previously we were requesting data from all peers atleast once. synced data 2 times in 90m, previous attempt on my computer was 1 week ago and took 12h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #5127 #5036
peers that are overwhelmed or generally will not be used for requests. there are two criteria used to select good peer:
related: #4977
limits number of peers to request data for atxs. previously we were requesting data from all peers atleast once.
synced data 2 times in 90m, previous attempt on my computer was 1 week ago and took 12h