-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - spawn a process to download atxs hinted by a server #5377
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #5377 +/- ##
=========================================
- Coverage 77.3% 77.3% -0.1%
=========================================
Files 257 258 +1
Lines 30472 30526 +54
=========================================
+ Hits 23570 23597 +27
- Misses 5408 5432 +24
- Partials 1494 1497 +3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There still is the question of will disabling sync break RegisterForATXSync()
? Because If it does many parts of the node won't work correctly with the DisableAtxSync
config parameter set to true
.
it doesn't break that |
f84f882
to
9664efa
Compare
bors merge |
related: #5366 this change disables sync reconciliation at the end and start of epoch, normal atx downloading works the way it was working. instead it will ask peers for atxs that are recorded in the set, shared by the server.
Build failed: |
bors merge |
related: #5366 this change disables sync reconciliation at the end and start of epoch, normal atx downloading works the way it was working. instead it will ask peers for atxs that are recorded in the set, shared by the server.
Build failed: |
system tests were canceled early? bors merge |
related: #5366 this change disables sync reconciliation at the end and start of epoch, normal atx downloading works the way it was working. instead it will ask peers for atxs that are recorded in the set, shared by the server.
Pull request successfully merged into develop. Build succeeded: |
related: spacemeshos#5366 this change disables sync reconciliation at the end and start of epoch, normal atx downloading works the way it was working. instead it will ask peers for atxs that are recorded in the set, shared by the server.
related: #5366 this change disables sync reconciliation at the end and start of epoch, normal atx downloading works the way it was working. instead it will ask peers for atxs that are recorded in the set, shared by the server.
related: #5366 this change disables sync reconciliation at the end and start of epoch, normal atx downloading works the way it was working. instead it will ask peers for atxs that are recorded in the set, shared by the server.
related: #5366
this change disables sync reconciliation at the end and start of epoch, normal atx downloading works the way it was working.
instead it will ask peers for atxs that are recorded in the set, shared by the server.