Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - spawn a process to download atxs hinted by a server #5377

Closed
wants to merge 12 commits into from

Conversation

dshulyak
Copy link
Contributor

@dshulyak dshulyak commented Dec 19, 2023

related: #5366

this change disables sync reconciliation at the end and start of epoch, normal atx downloading works the way it was working.
instead it will ask peers for atxs that are recorded in the set, shared by the server.

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (3c26d0b) 77.3% compared to head (0e11540) 77.3%.
Report is 1 commits behind head on develop.

Files Patch % Lines
node/node.go 0.0% 13 Missing ⚠️
syncer/atxsync/atxsync.go 70.2% 8 Missing and 3 partials ⚠️
syncer/syncer.go 0.0% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           develop   #5377     +/-   ##
=========================================
- Coverage     77.3%   77.3%   -0.1%     
=========================================
  Files          257     258      +1     
  Lines        30472   30526     +54     
=========================================
+ Hits         23570   23597     +27     
- Misses        5408    5432     +24     
- Partials      1494    1497      +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dshulyak dshulyak marked this pull request as ready for review December 19, 2023 12:09
syncer/atxsync/atxsync.go Outdated Show resolved Hide resolved
node/node.go Outdated Show resolved Hide resolved
syncer/syncer.go Outdated Show resolved Hide resolved
syncer/atxsync/atxsync_test.go Outdated Show resolved Hide resolved
syncer/atxsync/atxsync_test.go Outdated Show resolved Hide resolved
syncer/atxsync/atxsync.go Show resolved Hide resolved
syncer/syncer.go Outdated Show resolved Hide resolved
Copy link
Member

@fasmat fasmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There still is the question of will disabling sync break RegisterForATXSync()? Because If it does many parts of the node won't work correctly with the DisableAtxSync config parameter set to true.

fasmat added a commit that referenced this pull request Dec 20, 2023
fasmat added a commit that referenced this pull request Dec 20, 2023
@dshulyak
Copy link
Contributor Author

There still is the question of will disabling sync break RegisterForATXSync()? Because If it does many parts of the node won't work correctly with the DisableAtxSync config parameter set to true.

it doesn't break that

@dshulyak dshulyak force-pushed the donwload-hinted-atxs branch from f84f882 to 9664efa Compare December 21, 2023 08:19
@dshulyak
Copy link
Contributor Author

bors merge

spacemesh-bors bot pushed a commit that referenced this pull request Dec 21, 2023
related: #5366

this change disables sync reconciliation at the end and start of epoch, normal atx downloading works the way it was working.
instead it will ask peers for atxs that are recorded in the set, shared by the server.
@spacemesh-bors
Copy link

Build failed:

@fasmat
Copy link
Member

fasmat commented Dec 21, 2023

bors merge

spacemesh-bors bot pushed a commit that referenced this pull request Dec 21, 2023
related: #5366

this change disables sync reconciliation at the end and start of epoch, normal atx downloading works the way it was working.
instead it will ask peers for atxs that are recorded in the set, shared by the server.
@spacemesh-bors
Copy link

Build failed:

@fasmat
Copy link
Member

fasmat commented Dec 21, 2023

system tests were canceled early?

bors merge

spacemesh-bors bot pushed a commit that referenced this pull request Dec 21, 2023
related: #5366

this change disables sync reconciliation at the end and start of epoch, normal atx downloading works the way it was working.
instead it will ask peers for atxs that are recorded in the set, shared by the server.
@spacemesh-bors
Copy link

Pull request successfully merged into develop.

Build succeeded:

@spacemesh-bors spacemesh-bors bot changed the title spawn a process to download atxs hinted by a server [Merged by Bors] - spawn a process to download atxs hinted by a server Dec 21, 2023
@spacemesh-bors spacemesh-bors bot closed this Dec 21, 2023
dshulyak added a commit to dshulyak/go-spacemesh that referenced this pull request Dec 21, 2023
related: spacemeshos#5366

this change disables sync reconciliation at the end and start of epoch, normal atx downloading works the way it was working.
instead it will ask peers for atxs that are recorded in the set, shared by the server.
dshulyak added a commit that referenced this pull request Dec 21, 2023
related: #5366

this change disables sync reconciliation at the end and start of epoch, normal atx downloading works the way it was working.
instead it will ask peers for atxs that are recorded in the set, shared by the server.
dsmello pushed a commit that referenced this pull request Dec 28, 2023
related: #5366

this change disables sync reconciliation at the end and start of epoch, normal atx downloading works the way it was working.
instead it will ask peers for atxs that are recorded in the set, shared by the server.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants