[Merged by Bors] - Sync malfeasance proofs continuously #5718
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5718 +/- ##
========================================
Coverage 80.1% 80.1%
========================================
Files 283 285 +2
Lines 29410 29668 +258
========================================
+ Hits 23575 23784 +209
- Misses 4209 4243 +34
- Partials 1626 1641 +15 ☔ View full report in Codecov by Sentry. |
|
bors try |
tryBuild failed: |
|
bors try |
tryBuild failed: |
|
bors try |
tryBuild succeeded: |
syncer/syncer.go
Outdated
| @@ -267,6 +273,20 @@ func (s *Syncer) Start() { | |||
| } | |||
| } | |||
| }) | |||
| if !s.cfg.Standalone { | |||
| s.eg.Go(func() error { | |||
There was a problem hiding this comment.
i think it will be better if background jobs were spawned in the same place. in the syncAtx method we do synchronous requests and then spawn background job to check atxs from peers, maybe spawn background job for malfeasance sync there as well?
done |
ivan4th
force-pushed
the
feature/better-malfeasance-sync
branch
from
97f8228 to
b356f1f
Compare
|
bors merge |
|
Canceled. |
|
bors merge |
## Motivation Need to sync malfeasance proofs continuously to facilitate distributed verification. See #5306
|
Pull request successfully merged into develop. Build succeeded: |
spacemesh-bors
bot
changed the title
Motivation
Need to sync malfeasance proofs continuously to facilitate distributed verification. See #5306
Description
Implemented the proposed protocol from #5306 (comment)
For now malfeasance proof IDs are requested simultaneously from several peers, should the number of malfeasant identities grow substantially, we can make these requests sequential.
Test Plan
Verified on mainnet. Checked sync during startup and also by deleting malfeasance from db while
go-spacemeshis running to make sure they're restored during resync.TODO