Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport] Optimize searching for positioning ATX (#5952) #5966

Merged
merged 1 commit into from
May 21, 2024

Conversation

poszu
Copy link
Contributor

@poszu poszu commented May 21, 2024

No description provided.

@poszu poszu requested review from dshulyak, fasmat and ivan4th as code owners May 21, 2024 20:30
Searching for positioning ATX is slow because:
- the SQL query is slow
- it usually happens at the same time as many ATXs are being inserted into the DB (the poet CG)
@poszu poszu force-pushed the backport/1.5/5952 branch from 538838a to db15ee7 Compare May 21, 2024 20:32
Copy link

codecov bot commented May 21, 2024

Codecov Report

Attention: Patch coverage is 84.61538% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 80.5%. Comparing base (2dda34d) to head (db15ee7).
Report is 2 commits behind head on v1.5.

Files Patch % Lines
activation/activation.go 80.7% 8 Missing and 2 partials ⚠️
activation/post.go 71.4% 1 Missing and 1 partial ⚠️
atxsdata/data.go 92.0% 2 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            v1.5   #5966   +/-   ##
=====================================
  Coverage   80.5%   80.5%           
=====================================
  Files        286     286           
  Lines      29772   29818   +46     
=====================================
+ Hits       23982   24023   +41     
- Misses      4167    4171    +4     
- Partials    1623    1624    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fasmat fasmat merged commit 7aa1c0c into v1.5 May 21, 2024
20 checks passed
@fasmat fasmat deleted the backport/1.5/5952 branch May 21, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants