[Merged by Bors] - Fix/6041 bug #6053
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2. added comments
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6053 +/- ##
=========================================
- Coverage 81.4% 81.4% -0.1%
=========================================
Files 299 300 +1
Lines 32149 32196 +47
=========================================
+ Hits 26200 26238 +38
- Misses 4238 4245 +7
- Partials 1711 1713 +2 ☔ View full report in Codecov by Sentry. |
ConvallariaMaj
requested review from
dshulyak,
fasmat,
poszu,
ivan4th and
acud
as code owners
fasmat
requested changes
Jun 20, 2024
acud
reviewed
Jun 20, 2024
fasmat
reviewed
Jun 21, 2024
poszu
reviewed
Jun 24, 2024
acud
approved these changes
Jun 25, 2024
poszu
reviewed
Jun 25, 2024
poszu
approved these changes
Jun 26, 2024
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Jun 26, 2024
## Motivation Fix the bug Co-authored-by: ConvallariaMaj <[email protected]>
|
Build failed (retrying...): |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Jun 26, 2024
## Motivation Fix the bug Co-authored-by: ConvallariaMaj <[email protected]>
|
Pull request successfully merged into develop. Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix the bug
Description
Fix of issue #6041
Added timeout to context for searching positioning ATX, wrote couple new tests, extended offloadingPostVerifier.Verify() method to prioritize verificaiton of positioning ATX candidate.
Test Plan