Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[node-split] Tune PoC startup script #6520

Open
wants to merge 1 commit into
base: node-split-poc
Choose a base branch
from

Conversation

jellonek
Copy link
Contributor

@jellonek jellonek commented Dec 5, 2024

As in the title.

Extracted from #6506

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.2%. Comparing base (49bbb0b) to head (7e9ad71).
Report is 1 commits behind head on node-split-poc.

Additional details and impacted files
@@              Coverage Diff               @@
##           node-split-poc   #6520   +/-   ##
==============================================
  Coverage            77.2%   77.2%           
==============================================
  Files                 342     342           
  Lines               45839   45839           
==============================================
  Hits                35391   35391           
- Misses               8330    8338    +8     
+ Partials             2118    2110    -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jellonek jellonek changed the title Tune PoC startup script [node-split] Tune PoC startup script Dec 5, 2024
export IMAGE=$(docker images | head -n 2 | tail -n 1 | awk '{print $3}')
make -C .. dockerbuild-go

export IMAGE=$(docker images | awk 'FNR == 2 { print $3 }')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docker images docs do not seem to indicate guaranteed order of the items listed, so it's not very reliable to do this. You may want to use

docker images --format json | jq -rs 'sort_by(.CreatedAt)|last|.ID'

or follow this approach

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably not very important for a PoC, but given that this snippet may be copied later for some other use and then wrong image may be used, leading to unwanted surprises, we may want to be more careful ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants