Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend certifier limits configuration to avoid OOMs #271

Merged
merged 1 commit into from
May 28, 2024

Conversation

poszu
Copy link
Collaborator

@poszu poszu commented May 23, 2024

  • limit maximum pending requests, reject too many with 429
  • limit maximum request payload, reject too big with 413

- limit maximum pending requests, reject too many with 429
- limit maximum request payload, reject too big with 413
@poszu poszu requested a review from pigmej May 23, 2024 11:40
Copy link

codecov bot commented May 23, 2024

Codecov Report

Attention: Patch coverage is 73.52941% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 94.18%. Comparing base (a868a7b) to head (c2b3a56).

Files Patch % Lines
certifier/src/certifier.rs 83.33% 5 Missing ⚠️
certifier/src/configuration.rs 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #271      +/-   ##
==========================================
- Coverage   94.39%   94.18%   -0.21%     
==========================================
  Files          27       27              
  Lines        3352     3386      +34     
==========================================
+ Hits         3164     3189      +25     
- Misses        188      197       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@poszu poszu marked this pull request as ready for review May 23, 2024 13:02
@poszu poszu requested a review from fasmat May 24, 2024 09:25
@poszu poszu merged commit 2d16701 into main May 28, 2024
39 of 40 checks passed
@poszu poszu deleted the certifier/limit-queued-requests-and-payload branch May 28, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants