-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: k2pow service #362
feat: k2pow service #362
Conversation
e8bc2ee
to
67e7e46
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #362 +/- ##
==========================================
- Coverage 94.08% 93.09% -1.00%
==========================================
Files 27 29 +2
Lines 3383 3633 +250
==========================================
+ Hits 3183 3382 +199
- Misses 200 251 +51 ☔ View full report in Codecov by Sentry. |
710c1ab
to
9d194ba
Compare
curling the request works curl -XPOST localhost:3000/job/11/1122334455667788/aabbccddeeff00112233aabbccddeeff00112233aabbccddeeff001122334455/aabbccddeeff00112233aabbccddeeff00112233aabbccddeeff001122334455 wip wip wip wip wip wip cleanup wip chore: add to ci wip compiled compiling again cleanup wip-svc wip wip wip pick implementation explicitly add sleep simplify add par expectation clippy cleanups wip integrate into service change to dynamic dispatch for Prover implementations add logging wip add more configuration options add test vector with mock remote k2pow server fix certifier test cleanup lint
Co-authored-by: Bartosz Różański <[email protected]>
Co-authored-by: Bartosz Różański <[email protected]>
Co-authored-by: Bartosz Różański <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally, looking good! Only few small things left :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is one small thing still open: #362 (comment).
Otherwise LGTM:)
Work in progress.
As discussed with NJ, this implementation will:
closes #343