Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small GUI tweaks: spawning account and button labels #101

Merged
merged 6 commits into from
Oct 3, 2024
Merged

Conversation

brusherru
Copy link
Member

No issue.

It contains some tweaks, each in the separate commit.
So you can check them out one by one.

  1. Changed labels of the button in password prompts, sometime there was a pretty long labels that does not fit the button width. For example, replaced "Enter password to sign transaction" with "Sign transaction".

  2. Added missing padding in Send transaction popup for "Spawn" transaction (not SelfSpawn!)

  3. On the same screen disabled already spawned accounts in the dropdown.
    However, wallet app does not fetch all the transactions for all the accounts in the beginning. It will fetch them only when you switch to the account due to not overload API with huge amount of requests. So if you didn't switch to some account — it won't be disabled.

    • The good news, that @kacpersaw is already working on improvement of API to make it possible and cheap to retrieve a list of spawned accounts. Then it will be added and work perfectly.
    • Another good news, that even if User will submit Spawn transaction for already spawned account it will be rejected pretty soon and won't stuck in the mempool.
  4. Added hints about spawning account to reduce User's confusion about it.
    These hints are displayed only until account is Spawned.
    It has three states:

    • (1) no funds (or less than 105k smidges, which is required for SelfSpawn transaction)
      image
    • (2) instructions how to send self-spawn transaction
      image
    • (3) waiting for the transaction to be applied
      image

@brusherru brusherru self-assigned this Sep 27, 2024
Copy link

You can preview the changes at : https://2e5d1cab.smapp-lite-prod.pages.dev

src/components/AccountActionHints.tsx Outdated Show resolved Hide resolved
src/components/AccountActionHints.tsx Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Oct 1, 2024

You can preview the changes at : https://a05d6532.smapp-lite-prod.pages.dev

@brusherru brusherru merged commit a34e5c1 into main Oct 3, 2024
1 check passed
@brusherru brusherru deleted the tweak-gui branch October 3, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants