-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add message signing and verifying #97
Conversation
You can preview the changes at : https://fb880be8.smapp-lite-prod.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general OK but the error/success msgs should be fixed.
The success message once appears, stays sticked forever.
Screen.Recording.2024-09-24.at.14.06.20.mov
In the end of the recording I tried to put different kinds of incorrect signature content and the button [Verify] seemed like doing nothing/not working at all. Checked again with a new obviously incorrect input, and the button doesn’t respond with "check ->throw error", acts as if there was no onClick implemented.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
noticed the typo
a354bda
to
70685c4
Compare
You can preview the changes at : https://43e9f596.smapp-lite-prod.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
You can preview the changes at : https://132177e9.smapp-lite-prod.pages.dev |
You can preview the changes at : https://077f1ca5.smapp-lite-prod.pages.dev |
It closes #85.
This PR does not add support of signing messages by Ledger devices, because it requires some tweaks on Ledger App side.
Note for third-party developers:
Signature for the message calculated with a hard-coded prefix
Message:
which is encoded asUint8Array [77, 101, 115, 115, 97, 103, 101, 58]
to avoid possible vector of attack. So theverify
function should add this prefix to the message to be able to validate correct signature.Example: