Remove the use of pkg_resources
#8095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces its use with setuptools_scm
This was referenced Nov 27, 2023
|
Regression test run started at https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1066/ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8095 +/- ##
=======================================
Coverage 75.92% 75.93%
=======================================
Files 459 459
Lines 37615 37601 -14
=======================================
- Hits 28561 28553 -8
+ Misses 9054 9048 -6
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Two regression failures are unrelated. Merging. |
hbushouse
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, JWST makes use of the long deprecated (since python 3.3) module
pkg_resources. This module was officially removed for Python 3.12+ by python/cpython#98040. This PR removes all remaining uses ofpkg_resourcesfrom JWST, replacing the version generation withsetuptools_scmgenerating a hidden python file during install, which is the standard practice for using a git tag/commit versioned python project now.Checklist for maintainers
CHANGES.rstwithin the relevant release sectionHow to run regression tests on a PR