Upgrade to mina 1.2 #54
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrating to idiomatic mina 1.2.3, including the use of `fetch`, `ensure!`, `command`, and `invoke` [helpers](https://github.com/mina-deploy/mina/blob/master/docs/writing_your_own_tasks.md). The mina migration guide will help consumers: When migrating dependent projects, use the mina migration guide
cromwellryan
force-pushed
the
upgrade-mina
branch
from
fae3c70
to
4f594b3
Compare
Awesome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Couple things going on here:
lib/mina-circle/tasks.rb.test/config/deploy.rb.Idiomatic Mina DSL
Mina has eliminated some of the dynamic helpers such as
print_str, getters for variables, etc. Some of the things you will see in the mina-circle task implementation are:required_settingsas a list of symbols representing the settings a consuming deploy should have set.ensure!andfetchthe setting.required_settingsTest Deploy Script
If you
cd test, you can runmina deployand it will locally runmina-circle. For this PR, it is pointing at Tire Discounters. This is a baby step to a full integration test that I think we can run in CircleCI.Before committing this PR, those settings should be replaced with placeholders, but I'll leave them for ease of testing for now.