Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: try using ruby_memcheck to look for leaks #2344

Merged
merged 4 commits into from
Dec 10, 2021
Merged

test: try using ruby_memcheck to look for leaks #2344

merged 4 commits into from
Dec 10, 2021

Conversation

flavorjones
Copy link
Member

@flavorjones flavorjones commented Oct 21, 2021 •
edited
Loading

What problem is this PR intended to solve?

@peterzhu2118 and I paired on getting his ruby_memcheck gem running in Nokogiri.

This is an experiment, but this approach promises to avoid all the noisy false positives that valgrind's --leak-check tends to emit.

It:

  • adds ruby_memcheck as a dev dependency
  • adds a rake task
  • adds a CI task to run that rake task

@flavorjones flavorjones force-pushed the flavorjones-valgrind-memcheck-experiment branch 2 times, most recently from a50a566 to 3f6fbee Compare October 22, 2021 14:06
@flavorjones flavorjones mentioned this pull request Oct 22, 2021
Merged
@flavorjones flavorjones force-pushed the flavorjones-valgrind-memcheck-experiment branch from 3f6fbee to f00df45 Compare October 22, 2021 14:18
@flavorjones flavorjones mentioned this pull request Oct 22, 2021
Merged
@flavorjones flavorjones force-pushed the flavorjones-valgrind-memcheck-experiment branch 3 times, most recently from b378ac3 to b7bc5a9 Compare November 4, 2021 15:05
@flavorjones flavorjones force-pushed the flavorjones-valgrind-memcheck-experiment branch from b7bc5a9 to 14d11e0 Compare November 28, 2021 02:07
@flavorjones flavorjones force-pushed the flavorjones-valgrind-memcheck-experiment branch 3 times, most recently from 7be5c38 to 94813be Compare December 8, 2021 14:47
@flavorjones
ci: use ruby_memcheck to look for leaks
00fb5ce
@flavorjones
ci: default suppress glibc's strncmp (Addr16)
1470d28
@flavorjones
ci: todolist the remaining memcheck leak failures
bc597c2 
The remaining leaks are small. Some are from exception handling
detailed at #1610 and being worked on in #2096.

This allows us to detect and new memory leaks introduced.
@flavorjones
wip trying to debug ci
1381e62
@flavorjones flavorjones force-pushed the flavorjones-valgrind-memcheck-experiment branch from 94813be to 1381e62 Compare December 10, 2021 06:49
@flavorjones flavorjones merged commit 016070f into main Dec 10, 2021
@flavorjones flavorjones deleted the flavorjones-valgrind-memcheck-experiment branch December 10, 2021 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@flavorjones