Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
libxml2 just released v2.10.0. Full change log is at https://download.gnome.org/sources/libxml2/2.10/libxml2-2.10.0.news.
Details about this PR:
Note that one CVE is named in the upstream changelog, but it names python
lxml
and I was unable to reproduce using Nokogiri's API, so I'm not going to call it out in the changelog.Have you included adequate test coverage?
Current coverage is fine.
Does this change affect the behavior of either the C or the Java implementations?
This may change the behavior of the C implementation, but tests should provide coverage. We've been regularly running CI against upstream master.