fix: html5 encoding detection case insensitive re: meta tag #2693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flavorjones
force-pushed
the
flavorjones-html5-meta-encoding-detection
branch
from
07b5101
to
6636e86
Compare
stevecheckoway
approved these changes
Nov 14, 2022
There was a problem hiding this comment.
This change seems good.
The implementation of the prescan algorithm is incomplete though.
I added a note to #2513 so this won't get forgotten. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
I found an interesting test failure while playing with upgrading Mastodon to use the HTML5 parser that was caused by case-sensitivity in the HTML5 encoding detection.
Have you included adequate test coverage?
Yes.
Does this change affect the behavior of either the C or the Java implementations?
N/A