fix(jruby): serializing HTML with no save options emits HTML #2803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously this emitted XML. this brings the implementation into agreement with the CRuby implementation.
flavorjones
force-pushed
the
flavorjones-fix-jruby-html-serialization-no-save-options
branch
from
06d64c6
to
5242eff
Compare
flavorjones
deleted the
flavorjones-fix-jruby-html-serialization-no-save-options
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
On JRuby, serializing an HTML node or document without specifying save options (as with calling
#write_to) would emit XML. Now this mimics the libxml2 behavior of emitting HTML.This PR also contains a commit to close #2767 by making
SaveOptions#inspectcontain the names of the options set.Have you included adequate test coverage?
Yes!
Does this change affect the behavior of either the C or the Java implementations?
Bringing the Java impl into agreement with CRuby impl.