This repository has been archived by the owner on Jan 18, 2022. It is now read-only.
Add LinkedGameObjectMap API
#1013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
July 3, 2019 11:49
map docs
sub manager part 2
improbable-prow-robot
added
A: core
zeroZshadow
approved these changes
Jul 3, 2019
paulbalaji
reviewed
Jul 3, 2019
workers/unity/Packages/com.improbable.gdk.core/Subscriptions/LinkedGameObjectMap.cs
Outdated
Show resolved
Hide resolved
workers/unity/Packages/com.improbable.gdk.core/Subscriptions/LinkedGameObjectMap.cs
Outdated
Show resolved
Hide resolved
paulbalaji
approved these changes
Jul 3, 2019
added 2 commits
July 3, 2019 17:41
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added an API to expose the
EntityId -> [GameObject]relationship. This is wrapped in an object to ensure that we expose a list which is readonly (we really don't want users to mutate the underlying data).Also added a subscription manager for this (only in the GameObjectCreation module as the linker actually lives in a system here!) and added tests for this.
Commits are ordered and logical!
Tests
Added some tests for the subscription fulfillment.
Documentation