Skip to content
This repository has been archived by the owner on Jan 18, 2022. It is now read-only.

Add receptionist flow testing #1095

Merged
merged 7 commits into from
Aug 8, 2019

Conversation

jamiebrynes7
Copy link
Contributor

@jamiebrynes7 jamiebrynes7 commented Aug 6, 2019

Description

  • SpatialDeploymentManager.Start() builds worker configs as well (so that you may actually connect a worker)
  • Added tests for the ReceptionistFlow

Tests

Yes this is test.

Documentation

  • Changelog

@improbable-prow-robot improbable-prow-robot added jira/no-ticket Indicates a PR has no corresponding JIRA ticket A: core Area: Core GDK size/L Denotes a PR that changes 150-299 lines, ignoring generated files. labels Aug 6, 2019
Jamie Brynes and others added 2 commits August 6, 2019 16:20
Co-Authored-By: Paul Balaji <[email protected]>
public class ReceptionistFlowTests
{
private SpatialDeploymentManager deploymentManager;
private Improbable.Worker.CInterop.Connection connection;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this full typed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It conflicts with the current namespace: namespace Improbable.Gdk.Core.EditmodeTests.Connection

@jamiebrynes7 jamiebrynes7 merged commit bd7b903 into develop Aug 8, 2019
@jamiebrynes7 jamiebrynes7 deleted the feature/receptionist-flow-testing branch August 8, 2019 10:32
jessicafalk pushed a commit that referenced this pull request Nov 15, 2019
* Clean up worker entity on destroy

* Rename WeakThis to WeakSender
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A: core Area: Core GDK jira/no-ticket Indicates a PR has no corresponding JIRA ticket size/L Denotes a PR that changes 150-299 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants