Skip to content
This repository has been archived by the owner on Jan 18, 2022. It is now read-only.

opt-in reactive providers #1113

Merged
merged 6 commits into from
Aug 14, 2019
Merged

opt-in reactive providers #1113

merged 6 commits into from
Aug 14, 2019

Conversation

zeroZshadow
Copy link
Contributor

Description

We forgot to add the providers for reactive components to the #ifdef
This fixes this, and contains a driveby fix on a global namespace.

Tests

Tested in Playground and test project

@zeroZshadow zeroZshadow self-assigned this Aug 14, 2019
@improbable-prow-robot improbable-prow-robot added jira/no-ticket Indicates a PR has no corresponding JIRA ticket size/XXL Denotes a PR that changes 600+ lines, ignoring generated files. A: tooling Area: Tooling labels Aug 14, 2019
@paulbalaji
Copy link
Contributor

changelog?

CHANGELOG.md Outdated Show resolved Hide resolved
Co-Authored-By: Jamie Brynes <[email protected]>
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Co-Authored-By: Paul Balaji <[email protected]>
@zeroZshadow zeroZshadow merged commit 359e8c8 into develop Aug 14, 2019
@zeroZshadow zeroZshadow deleted the feature/reative-providers branch August 14, 2019 15:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A: tooling Area: Tooling jira/no-ticket Indicates a PR has no corresponding JIRA ticket size/XXL Denotes a PR that changes 600+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants