This repository has been archived by the owner on Jan 18, 2022. It is now read-only.
Network Analyzer - Updates #1148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
improbable-prow-robot
added
jira/no-ticket
|
please add a screenshot to the PR description |
jamiebrynes7
suggested changes
Sep 6, 2019
workers/unity/Packages/io.improbable.gdk.debug/NetStatViewer.cs
Outdated
Show resolved
Hide resolved
workers/unity/Packages/io.improbable.gdk.debug/NetStatViewer.cs
Outdated
Show resolved
Hide resolved
workers/unity/Packages/io.improbable.gdk.debug/NetStatViewer.cs
Outdated
Show resolved
Hide resolved
workers/unity/Packages/io.improbable.gdk.debug/Templates/NetStatsWindow.uxml
Outdated
Show resolved
Hide resolved
workers/unity/Packages/io.improbable.gdk.debug/Templates/NetStatsWindow.uxml
Outdated
Show resolved
Hide resolved
workers/unity/Packages/io.improbable.gdk.debug/Templates/UpdateRow.uss
Outdated
Show resolved
Hide resolved
Temporary names and locations for UI files
Print Component Update stats
Change from List to ScrollView for better performance
Co-Authored-By: Jamie Brynes <[email protected]>
…atsWindow.uxml Co-Authored-By: Jamie Brynes <[email protected]>
…atsWindow.uxml Co-Authored-By: Jamie Brynes <[email protected]>
zeroZshadow
force-pushed
the
feature/netstat-ui
branch
from
6abf13d to
3a49a19
Compare
jamiebrynes7
approved these changes
Sep 6, 2019
|
LGTM % the comment above:
|
paulbalaji
approved these changes
Sep 6, 2019
|
|
||
| // Incoming stats | ||
| var (dataIn, time) = | ||
| netStatSystem.GetSummary(MessageTypeUnion.Update(componentId), 60, Direction.Incoming); |
There was a problem hiding this comment.
do we want to hardcode at 60?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add initial implementation of the Network Analyzer window.
Currently only implements the Updates tab.
Tests
Tested with playground.
Documentation
Will add documentation once the other 2 tabs are done.