This repository has been archived by the owner on Jan 18, 2022. It is now read-only.
Add component metaclass / command metaclasses #1173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
improbable-prow-robot
added
jira/no-ticket
improbable-prow-robot
added
size/XXL
zeroZshadow
reviewed
Sep 23, 2019
workers/unity/Packages/io.improbable.gdk.core/Worker/MessagesToSend.cs
Outdated
Show resolved
Hide resolved
jessicafalk
approved these changes
Sep 26, 2019
workers/unity/Packages/io.improbable.gdk.core/Dynamic/ComponentDatabase.cs
Show resolved
Hide resolved
jessicafalk
pushed a commit
that referenced
this pull request
Nov 15, 2019
* Cleanup dynamic objects on entity removal * PR feedback
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the quest to expose (component ID, command index) -> command name pairs in preparation for command network stats GUI work, we found that we could simplify and reduce the amount of reflection required at startup by introducing metadata classes.
Whereas previously, for every type we wanted to reflect over related to a component (i.e. - serializer, diff storage, etc) we would do a full search through all the assemblies for these types.
Now we statically generate this information in the metaclass and do reflection once to find those metaclasses. This also has the benefit of allowing us to expose the information ((component ID, command index) -> command name pairs) that we originally wanted in a clean way.
Along the way we made a small breaking change to improve the coherency of the API.
Tests
Documentation
❓ Docs?Turns out there are none