This repository has been archived by the owner on Jan 18, 2022. It is now read-only.
Codegen Split: GameObject Creation #1196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
improbable-prow-robot
added
do-not-merge/work-in-progress
paulbalaji
reviewed
Oct 17, 2019
| using Improbable.Gdk.CodeGeneration.Model.Details; | ||
| using Improbable.Gdk.CodeGeneration.Utils; | ||
|
|
||
| namespace Improbable.Gdk.CodeGenerator.GameObjectCreation |
There was a problem hiding this comment.
I think we should rename this module since it encompasses everything to do with game objects (not just creation)
There was a problem hiding this comment.
Agreed, though out of scope for this
...ity/Packages/io.improbable.gdk.gameobjectcreation/.codegen/Source/GameObjectGenerationJob.cs
Outdated
Show resolved
Hide resolved
zeroZshadow
force-pushed
the
feature/codegen-gameobject-split
branch
from
b50d261 to
f0de3a0
Compare
jamiebrynes7
approved these changes
Oct 21, 2019
.../unity/Packages/io.improbable.gdk.gameobjectcreation/.codegen/Source/GameObjectCodegenJob.cs
Outdated
Show resolved
Hide resolved
improbable-prow-robot
removed
the
do-not-merge/work-in-progress
jessicafalk
pushed a commit
that referenced
this pull request
Nov 15, 2019
* Fix logging ErroredBlueprints with invalid pointers * Updated CHANGELOG.md for bugfix/UNR-1772-errored-blueprints-logging
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moved code generation files required for GameObject Creation support to the respective package.
Fixed missing dependency in TransformSync package.
Documentation