This repository has been archived by the owner on Jan 18, 2022. It is now read-only.
Fix command response key leak #1205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
improbable-prow-robot
added
the
jira/no-ticket
improbable-prow-robot
added
A: core
paulbalaji
approved these changes
Oct 31, 2019
Co-Authored-By: Paul Balaji <[email protected]>
jessicafalk
approved these changes
Oct 31, 2019
jamiebrynes7
approved these changes
Oct 31, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Command response callbacks were registering a key with the system, but these were never cleared.
The key itself isn't actually used, since response callbacks will always clean up after sending.
This PR removes the key registration for response callbacks.