This repository has been archived by the owner on Jan 18, 2022. It is now read-only.
Port component/command diff storage/deserializer generators #1251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 20, 2020 17:02
improbable-prow-robot
added
the
jira/no-ticket
improbable-prow-robot
added
A: core
zeroZshadow
reviewed
Jan 21, 2020
...s/io.improbable.gdk.core/.codegen/Source/Generators/Core/CommandDiffDeserializerGenerator.cs
Outdated
Show resolved
Hide resolved
| { | ||
| Logger.Trace($"Generating {qualifiedNamespace}.{componentName}.{command.CommandName}CommandsToSendStorage class."); | ||
|
|
||
| var requestType = $"{command.CommandName}.Request"; |
There was a problem hiding this comment.
I've left it in where we use it several times
...io.improbable.gdk.core/.codegen/Source/Generators/Core/ComponentDiffDeserializerGenerator.cs
Outdated
Show resolved
Hide resolved
...io.improbable.gdk.core/.codegen/Source/Generators/Core/ComponentDiffDeserializerGenerator.cs
Outdated
Show resolved
Hide resolved
...ages/io.improbable.gdk.core/.codegen/Source/Generators/Core/ComponentDiffStorageGenerator.cs
Outdated
Show resolved
Hide resolved
|
|
||
| foreach (var ev in eventDetailsList) | ||
| { | ||
| var eventType = $"{ev.EventName}.Event"; |
There was a problem hiding this comment.
I've seen this so often now, it should probably be a property on the ev type
There was a problem hiding this comment.
indeed - it should be :)
paulbalaji
force-pushed
the
feature/port-core-part-3
branch
from
8afaf46 to
81a6366
Compare
zeroZshadow
approved these changes
Jan 22, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ported
Tests
see generated code
Documentation
will add changelog entry in final core port pr
Primary reviewers
If your change will take a long time to review, you can name at most two primary reviewers who are ultimately responsible for reviewing this request. @ mention them.