Skip to content
This repository has been archived by the owner on Jan 18, 2022. It is now read-only.

Finish porting core codegen module #1253

Merged
merged 5 commits into from
Jan 22, 2020
Merged

Finish porting core codegen module #1253

merged 5 commits into from
Jan 22, 2020

Conversation

paulbalaji
Copy link
Contributor

@paulbalaji paulbalaji commented Jan 20, 2020 •
edited
Loading

Description

  • ported component data generator
  • ported component sender generator
  • removed T4 step from solution file (to make codegen work)

Tests

see generated code

Documentation

  • changelog

Primary reviewers

If your change will take a long time to review, you can name at most two primary reviewers who are ultimately responsible for reviewing this request. @ mention them.

@improbable-prow-robot improbable-prow-robot added the jira/no-ticket Indicates a PR has no corresponding JIRA ticket label Jan 20, 2020
@improbable-prow-robot improbable-prow-robot added size/XXL Denotes a PR that changes 600+ lines, ignoring generated files. A: core Area: Core GDK A: tooling Area: Tooling labels Jan 20, 2020
@paulbalaji paulbalaji force-pushed the feature/port-core-part-5 branch from ab223ab to ae00dd4 Compare January 20, 2020 19:32
@paulbalaji paulbalaji force-pushed the feature/port-core-part-5 branch from ae00dd4 to 73376f8 Compare January 22, 2020 15:32
@paulbalaji paulbalaji force-pushed the feature/port-core-part-5 branch from 73376f8 to 1826911 Compare January 22, 2020 15:39
@improbable-prow-robot improbable-prow-robot added the A: game-object-creation Area: Gameobject creation feature module label Jan 22, 2020
@paulbalaji paulbalaji changed the base branch from feature/port-core-part-4 to develop January 22, 2020 15:40
@paulbalaji paulbalaji merged commit 1427f5b into develop Jan 22, 2020
@paulbalaji paulbalaji deleted the feature/port-core-part-5 branch January 22, 2020 15:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zeroZshadow zeroZshadow zeroZshadow approved these changes

@jamiebrynes7 jamiebrynes7 Awaiting requested review from jamiebrynes7

@jessicafalk jessicafalk Awaiting requested review from jessicafalk

Assignees
No one assigned
Labels
A: core Area: Core GDK A: game-object-creation Area: Gameobject creation feature module A: tooling Area: Tooling jira/no-ticket Indicates a PR has no corresponding JIRA ticket size/XXL Denotes a PR that changes 600+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulbalaji @zeroZshadow @improbable-prow-robot