This repository has been archived by the owner on Jan 18, 2022. It is now read-only.
Actually skip missing, non-required build targets. #1257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Corresponding JIRA ticket: https://improbableio.atlassian.net/browse/UTY-2415 |
improbable-prow-robot
added
do-not-merge/work-in-progress
jessicafalk
approved these changes
Jan 28, 2020
improbable-prow-robot
added
the
A: build-system
zeroZshadow
approved these changes
Jan 28, 2020
improbable-prow-robot
removed
the
do-not-merge/work-in-progress
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tiny bug fix to the build system. Previously we would call out missing targets, but then try to build them anyway 😬
Tests
Documentation