CN environment support #1260
CN environment support #1260
Conversation
improbable-prow-robot
added
jira/no-ticket
zeroZshadow
force-pushed
the
feature/environment-support
branch
from
3596f6c to
0e86df7
Compare
|
Adding support for the cn-production environment to our |
workers/unity/Packages/io.improbable.gdk.tools/DevAuthTokenUtils.cs
Outdated
Show resolved
Hide resolved
| { | ||
| // These are the last tested values | ||
| Heartbeat = new HeartbeatParameters | ||
| DownstreamHeartbeat = new HeartbeatParameters |
There was a problem hiding this comment.
They were the last tested values 
...ers/unity/Packages/io.improbable.gdk.deploymentlauncher/.DeploymentLauncher/ClientFactory.cs
Outdated
Show resolved
Hide resolved
...s/unity/Packages/io.improbable.gdk.deploymentlauncher/.DeploymentLauncher/Commands/Create.cs
Show resolved
Hide resolved
| .WithArgs("file", "zip", $"--output=\"{Path.GetFullPath(zipPath)}\"", | ||
| RedirectedProcess | ||
| .Spatial("file", "zip") | ||
| .WithArgs($"--output=\"{Path.GetFullPath(zipPath)}\"", |
There was a problem hiding this comment.
So looking at this API, what happens if I put the current args with file and zip?
There was a problem hiding this comment.
Could you give an example?
There was a problem hiding this comment.
RedirectedProcess.Spatial("file", "zip", "--output=./something.zip", ...)
...ers/unity/Packages/io.improbable.gdk.deploymentlauncher/.DeploymentLauncher/ClientFactory.cs
Outdated
Show resolved
Hide resolved
...ers/unity/Packages/io.improbable.gdk.deploymentlauncher/.DeploymentLauncher/ClientFactory.cs
Show resolved
Hide resolved
| }; | ||
|
|
||
| var tokenFile = possibleTokenFiles.FirstOrDefault(File.Exists); | ||
| if (!string.IsNullOrEmpty(tokenFile)) |
There was a problem hiding this comment.
Why is this check required if we've ran it through File.Exists on the line above?
There was a problem hiding this comment.
This is also copied from the Platform SDK
| } | ||
|
|
||
| // Fail if no form of credentials could be found. | ||
| throw new NoRefreshTokenFoundException(""); |
There was a problem hiding this comment.
Put some message in this?
There was a problem hiding this comment.
It has a message internally which states it was unable to find the token file locally.
| @@ -181,6 +178,11 @@ private static string ModifySimulatedPlayerLaunchJson(Options.CreateSimulated op | |||
| var content = new ByteArrayContent(bytes); | |||
| content.Headers.Add("Content-MD5", snapshotToUpload.Checksum); | |||
|
|
|||
| if (options.Environment == "cn-production") | |||
| { | |||
| content.Headers.Add("x-amz-server-side-encryption", "AES256"); | |||
There was a problem hiding this comment.
Thanks @MatthewSandfordImprobable for the code
workers/unity/Packages/io.improbable.gdk.deploymentlauncher/.DeploymentLauncher/Options.cs
Outdated
Show resolved
Hide resolved
| { | ||
| // These are the last tested values | ||
| Heartbeat = new HeartbeatParameters | ||
| DownstreamHeartbeat = new HeartbeatParameters |
There was a problem hiding this comment.
They were the last tested values
improbable-prow-robot
removed
the
do-not-merge/work-in-progress
Description
Add support for the cn-production environment for workers and deployment launcher.
Upgraded the Worker and Platform SDK to 14.4.0, as the locator cannot connect otherwise.
Removed use of deprecated network protocols (Tests still exist)
Tests
Fully tested deployment launcher window to work.
Connected a client to a cloud deployment in cn-production using the locator.
Documentation