This repository has been archived by the owner on Jan 18, 2022. It is now read-only.
Simplify command codegen #1263
Merged
Simplify command codegen #1263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
improbable-prow-robot
added
jira/no-ticket
improbable-prow-robot
added
size/XXL
zeroZshadow
force-pushed
the
feature/simplify-command-codegen
branch
from
f540d7c to
55457c1
Compare
improbable-prow-robot
added
A: build-system
improbable-prow-robot
removed
the
do-not-merge/work-in-progress
paulbalaji
reviewed
Jan 31, 2020
paulbalaji
previously approved these changes
Jan 31, 2020
paulbalaji
approved these changes
Jan 31, 2020
| @@ -171,7 +171,7 @@ private static void Generate() | |||
| { | |||
| var option = EditorUtility.DisplayDialogComplex("Generate Code", | |||
| $"Code generation failed with {numWarnings} warnings and {numErrors} errors!{Environment.NewLine}{Environment.NewLine}" | |||
| + "Please check the code generation logs for more information: {loggerOutputPath}", | |||
| + $"Please check the code generation logs for more information: {loggerOutputPath}", | |||
jamiebrynes7
approved these changes
Feb 3, 2020
| workerSystem = world.GetExistingSystem<WorkerSystem>(); | ||
| if (workerSystem == null) | ||
| { | ||
| throw new ArgumentException("No worker"); |
| { | ||
| this.world = world; | ||
|
|
||
| // Check that these are there |
There was a problem hiding this comment.
Should we be checking & throwing here?
zeroZshadow
force-pushed
the
feature/simplify-command-codegen
branch
from
57b65d6 to
4a2dd57
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Codegen de-duplication for command.
This is a big one, go per commit.
Tests
Documentation