Skip to content
This repository has been archived by the owner on Jan 18, 2022. It is now read-only.

[4/5] Port modules to new CodegenJob model #1276

Merged
merged 5 commits into from
Feb 17, 2020
Merged

[4/5] Port modules to new CodegenJob model #1276

merged 5 commits into from
Feb 17, 2020

Conversation

paulbalaji
Copy link
Contributor

@paulbalaji paulbalaji commented Feb 12, 2020 •
edited
Loading

Description

  • Port modules to new CodegenJob model

Tests

  • no change in generated code

Documentation

  • changelog in final PR

Primary reviewers

If your change will take a long time to review, you can name at most two primary reviewers who are ultimately responsible for reviewing this request. @ mention them.

@improbable-prow-robot improbable-prow-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/no-ticket Indicates a PR has no corresponding JIRA ticket labels Feb 12, 2020
@improbable-prow-robot improbable-prow-robot added size/XL Denotes a PR that changes 300-599 lines, ignoring generated files. A: build-system Area: Build system feature module A: core Area: Core GDK A: game-object-creation Area: Gameobject creation feature module A: tooling Area: Tooling labels Feb 12, 2020
jamiebrynes7
jamiebrynes7 reviewed Feb 12, 2020
View reviewed changes
Copy link
Contributor

@jamiebrynes7 jamiebrynes7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for downgrading a lot of the infos -> traces for logs 💯

@paulbalaji paulbalaji changed the title [4/4] Port modules to new CodegenJob model [4/5] Port modules to new CodegenJob model Feb 13, 2020
@paulbalaji paulbalaji force-pushed the feature/codegen-update branch from dc25cb7 to 5e53f4e Compare February 17, 2020 16:09
@paulbalaji paulbalaji force-pushed the feature/cgn-port-modules branch from e8b2c22 to ac11e3a Compare February 17, 2020 16:32
@paulbalaji paulbalaji changed the base branch from feature/codegen-update to develop February 17, 2020 16:33
Paul Balaji added 5 commits February 17, 2020 16:33
port test project
f14ee17
fix testcodegenjob?
92004a7 
Signed-off-by: Paul Balaji <[email protected]>
port build system module
9723d62 
Signed-off-by: Paul Balaji <[email protected]>
port gameobject creation module
0747a15 
Signed-off-by: Paul Balaji <[email protected]>
port core module
8129d07 
Signed-off-by: Paul Balaji <[email protected]>
@paulbalaji paulbalaji force-pushed the feature/cgn-port-modules branch from ac11e3a to 8129d07 Compare February 17, 2020 16:33
@paulbalaji paulbalaji marked this pull request as ready for review February 17, 2020 16:33
@improbable-prow-robot improbable-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 17, 2020
@paulbalaji paulbalaji merged commit c6e12c1 into develop Feb 17, 2020
@zeroZshadow zeroZshadow deleted the feature/cgn-port-modules branch February 29, 2020 15:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jamiebrynes7 jamiebrynes7 jamiebrynes7 approved these changes

@zeroZshadow zeroZshadow zeroZshadow approved these changes

@jessicafalk jessicafalk Awaiting requested review from jessicafalk

Assignees
No one assigned
Labels
A: build-system Area: Build system feature module A: core Area: Core GDK A: game-object-creation Area: Gameobject creation feature module A: tooling Area: Tooling jira/no-ticket Indicates a PR has no corresponding JIRA ticket size/XL Denotes a PR that changes 300-599 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@paulbalaji @zeroZshadow @jamiebrynes7 @improbable-prow-robot