Skip to content
This repository has been archived by the owner on Jan 18, 2022. It is now read-only.

Remove customreplicators #1308

Merged
merged 6 commits into from
Mar 3, 2020
Merged

Remove customreplicators #1308

merged 6 commits into from
Mar 3, 2020

Conversation

zeroZshadow
Copy link
Contributor

@zeroZshadow zeroZshadow commented Feb 28, 2020 •
edited
Loading

Description

Remove the Custom Replicators and the system that supports them
Remove the ComponentId from the ECS component structs.

Re-ordered component structs to have fields FIRST and then the dirty bits functions.
This makes it much easier to see what data is on a component at a quick glance.

Documentation

  • Changelog

@improbable-prow-robot improbable-prow-robot added the jira/no-ticket Indicates a PR has no corresponding JIRA ticket label Feb 28, 2020
@improbable-prow-robot improbable-prow-robot added size/XXL Denotes a PR that changes 600+ lines, ignoring generated files. A: build-system Area: Build system feature module A: core Area: Core GDK A: game-object-creation Area: Gameobject creation feature module A: mobile Area: Mobile integration A: playground Area: Playground A: tooling Area: Tooling labels Feb 28, 2020
@zeroZshadow zeroZshadow changed the base branch from master to develop February 28, 2020 16:38
@improbable-prow-robot improbable-prow-robot added size/L Denotes a PR that changes 150-299 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 600+ lines, ignoring generated files. labels Feb 28, 2020
@zeroZshadow zeroZshadow changed the title Feature/remove customreplicators Remove customreplicators Feb 28, 2020
@zeroZshadow
Copy link
Contributor Author

I ran formatting on the generator, it seems to have changed a lot?

@jamiebrynes7
Copy link
Contributor

I ran formatting on the generator, it seems to have changed a lot?

If this is the formatter inside Rider, that's not entirely unexpected as I think our configurations have diverged over time (due to Rider's layer-based system). It looks like mostly line-length changes?

@zeroZshadow zeroZshadow force-pushed the feature/remove-customreplicators branch from 71adf37 to 4728485 Compare March 2, 2020 16:27
@improbable-prow-robot improbable-prow-robot added size/XL Denotes a PR that changes 300-599 lines, ignoring generated files. and removed size/L Denotes a PR that changes 150-299 lines, ignoring generated files. labels Mar 2, 2020
paulbalaji
paulbalaji approved these changes Mar 2, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@zeroZshadow zeroZshadow merged commit c0090d3 into develop Mar 3, 2020
@zeroZshadow zeroZshadow deleted the feature/remove-customreplicators branch March 3, 2020 14:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jamiebrynes7 jamiebrynes7 jamiebrynes7 approved these changes

@paulbalaji paulbalaji paulbalaji approved these changes

@jessicafalk jessicafalk Awaiting requested review from jessicafalk

Assignees
No one assigned
Labels
A: build-system Area: Build system feature module A: core Area: Core GDK A: game-object-creation Area: Gameobject creation feature module A: mobile Area: Mobile integration A: playground Area: Playground A: tooling Area: Tooling jira/no-ticket Indicates a PR has no corresponding JIRA ticket size/XL Denotes a PR that changes 300-599 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zeroZshadow @jamiebrynes7 @paulbalaji @improbable-prow-robot