This repository has been archived by the owner on Jan 18, 2022. It is now read-only.
Allow multi-frame entity checkout for GameObject creation #1330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
improbable-prow-robot
added
jira/no-ticket
improbable-prow-robot
added
the
size/XL
paulbalaji
commented
Mar 23, 2020
...nity/Packages/io.improbable.gdk.gameobjectcreation/Tests/Editmode/GameObjectCreationTests.cs
Show resolved
Hide resolved
zeroZshadow
reviewed
Mar 23, 2020
...ers/unity/Packages/io.improbable.gdk.gameobjectcreation/GameObjectInitializationComponent.cs
Outdated
Show resolved
Hide resolved
workers/unity/Packages/io.improbable.gdk.gameobjectcreation/GameObjectInitializationSystem.cs
Show resolved
Hide resolved
...nity/Packages/io.improbable.gdk.gameobjectcreation/Tests/Editmode/GameObjectCreationTests.cs
Outdated
Show resolved
Hide resolved
workers/unity/Packages/io.improbable.gdk.gameobjectcreation/GameObjectInitializationSystem.cs
Outdated
Show resolved
Hide resolved
workers/unity/Packages/io.improbable.gdk.gameobjectcreation/IEntityGameObjectCreator.cs
Outdated
Show resolved
Hide resolved
...gdk.gameobjectcreation/Tests/Editmode/Improbable.Gdk.GameObjectCreation.EditmodeTests.asmdef
Outdated
Show resolved
Hide resolved
.../io.improbable.gdk.gameobjectcreation/Tests/Editmode/LinkedGameObjectMapSubscriptionTests.cs
Outdated
Show resolved
Hide resolved
...nity/Packages/io.improbable.gdk.gameobjectcreation/Tests/Editmode/GameObjectCreationTests.cs
Outdated
Show resolved
Hide resolved
...nity/Packages/io.improbable.gdk.gameobjectcreation/Tests/Editmode/GameObjectCreationTests.cs
Show resolved
Hide resolved
paulbalaji
commented
Mar 23, 2020
...gdk.gameobjectcreation/Tests/Editmode/Improbable.Gdk.GameObjectCreation.EditmodeTests.asmdef
Show resolved
Hide resolved
added 4 commits
March 23, 2020 12:35
Signed-off-by: Paul Balaji <[email protected]>
Signed-off-by: Paul Balaji <[email protected]>
Signed-off-by: Paul Balaji <[email protected]>
zeroZshadow
reviewed
Mar 23, 2020
workers/unity/Packages/io.improbable.gdk.gameobjectcreation/AssemblyInfo.cs
Outdated
Show resolved
Hide resolved
zeroZshadow
approved these changes
Mar 23, 2020
added 2 commits
March 23, 2020 13:01
if it's null, we don't concat it with the |
paulbalaji
force-pushed
the
feature/better-gameobject-initialization
branch
from
6ff5db1 to
a62b9c2
Compare
|
Added changelog and short upgrade guide, please TAL |
paulbalaji
commented
Mar 23, 2020
jamiebrynes7
approved these changes
Mar 23, 2020
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We now perform gameobject creation on entities that match the minimum component set required by the creator, instead of any entity that is newly added.
This means we no longer care if the components are added to an entity in one frame or multiple.
Updated
MockWorldto let people provide constructor arguments for system creation.Tests
Documentation
Primary reviewers
If your change will take a long time to review, you can name at most two primary reviewers who are ultimately responsible for reviewing this request. @ mention them.