Skip to content
This repository has been archived by the owner on Jan 18, 2022. It is now read-only.

UTY-2659: set different entt list version #1432

Merged
merged 6 commits into from
Jul 22, 2020

Conversation

BryanJY-Wong
Copy link
Contributor

@BryanJY-Wong BryanJY-Wong commented Jul 20, 2020

Description

  • Fixed a bug in the Worker Inspector where switching to a worker with no entities checked out does not refresh the entity list correctly

Tests

Set up client worker to not checkout anything and switch from game logic to client view in worker inspector.

Documentation

  • Changelog

Primary reviewers

If your change will take a long time to review, you can name at most two primary reviewers who are ultimately responsible for reviewing this request. @ mention them.

@BryanJY-Wong BryanJY-Wong self-assigned this Jul 20, 2020
@improbable-prow-robot improbable-prow-robot added jira/no-ticket Indicates a PR has no corresponding JIRA ticket size/XS Denotes a PR that changes 0-14 lines, ignoring generated files. labels Jul 20, 2020
@BryanJY-Wong BryanJY-Wong changed the title set different entt list version UTY-2659: set different entt list version Jul 20, 2020
@improbable-prow-robot improbable-prow-robot removed the jira/no-ticket Indicates a PR has no corresponding JIRA ticket label Jul 20, 2020
@improbable-prow-robot
Copy link

Corresponding JIRA ticket: https://improbableio.atlassian.net/browse/UTY-2659

@BryanJY-Wong BryanJY-Wong changed the base branch from master to develop July 20, 2020 12:59
@BryanJY-Wong BryanJY-Wong force-pushed the bug/refresh-entt-list-correctly branch from 9a05a5a to f243a11 Compare July 20, 2020 16:16
@jamiebrynes7
Copy link
Contributor

Ah don't forget a changelog here 😄

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@BryanJY-Wong BryanJY-Wong merged commit 6927912 into develop Jul 22, 2020
@improbable-prow-robot improbable-prow-robot deleted the bug/refresh-entt-list-correctly branch July 22, 2020 09:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
jira/UTY size/XS Denotes a PR that changes 0-14 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants