This repository has been archived by the owner on Jan 18, 2022. It is now read-only.
Fix MacOS local launch errors when there are spaces in paths #1442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
improbable-prow-robot
added
do-not-merge/work-in-progress
improbable-prow-robot
added
A: tooling
improbable-prow-robot
removed
the
do-not-merge/work-in-progress
paulbalaji
approved these changes
Jul 29, 2020
| activate | ||
| do script ""cd {Common.SpatialProjectRootDir} && {Common.SpatialBinary} {commandArgs}"" | ||
| do script ""cd "" & quoted form of projectDir & "" && {Common.SpatialBinary} {commandArgs}"" |
There was a problem hiding this comment.
I find it almost magic how "quoted form of X" is valid osascript
There was a problem hiding this comment.
Yeah its pretty wild
jamiebrynes7
force-pushed
the
bugfix/macos-local-launch
branch
from
f530f7d to
95e1443
Compare
jamiebrynes7
force-pushed
the
bugfix/macos-local-launch
branch
from
95e1443 to
27f2d11
Compare
improbable-prow-robot
added
size/S
|
Kudos, SonarCloud Quality Gate passed!
|
BryanJY-Wong
approved these changes
Jul 29, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We use
osascriptfor launching a local deployment withspatial. This has some particular rules around quotation, especially as we are running the script inline from a shell.This resulted in errors when paths had spaces in them. To handle these, I've used the built-in quoting abilities in
osascriptrather than trying to escape them manually twice (once for shell and once for osascript!).Tests
gdk-for-unitytogdk for unityon my local machine to test launching a deployment & standalone client.Documentation