This repository has been archived by the owner on Jan 18, 2022. It is now read-only.
UTY-2646: new dotnet version #1443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Corresponding JIRA ticket: https://improbableio.atlassian.net/browse/UTY-2646 |
improbable-prow-robot
added
jira/UTY
size/XS
zeroZshadow
previously requested changes
Aug 3, 2020
workers/unity/.gitignore
Outdated
| @@ -23,3 +23,6 @@ | |||
| # Jetbrains | |||
| /Assets/Plugins/Editor/Jetbrains | |||
| /Assets/Plugins/Editor/Jetbrains.meta | |||
|
|
|||
| # Sonarcube dependency | |||
| global.json | |||
There was a problem hiding this comment.
This shouldn't be in the gitignore, and the file won't ever survive a test.sh run
There was a problem hiding this comment.
Why was this resolved?
There was a problem hiding this comment.
I think I clicked it by mistake when trying to resolve one of the other 2, anyway, I fixed it now
BryanJY-Wong
force-pushed
the
feature/new-dotnet-version
branch
from
acde967 to
a38e09d
Compare
paulbalaji
approved these changes
Aug 6, 2020
jamiebrynes7
approved these changes
Aug 10, 2020
Co-authored-by: Jamie Brynes <[email protected]>
Co-authored-by: Jamie Brynes <[email protected]>
BryanJY-Wong
dismissed
zeroZshadow’s stale review
2/3 changes made, last change not possible
zeroZshadow
approved these changes
Aug 11, 2020
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update queue with .NET Core SDK 3.1.302
Tests
Documentation
Did you remember a changelog entry?
Primary reviewers
If your change will take a long time to review, you can name at most two primary reviewers who are ultimately responsible for reviewing this request. @ mention them.