Skip to content
This repository has been archived by the owner on Jan 18, 2022. It is now read-only.

Move runtime IP to EditorPref / DevAuthToken to PlayerPref #961

Merged
merged 11 commits into from
Jun 3, 2019

Conversation

paulbalaji
Copy link
Contributor

@paulbalaji paulbalaji commented May 29, 2019

Description

  • move runtime ip to an editor pref
  • move DAT to player pref
    • this ties a DAT to a company/project_name
    • only create DAT.txt if enabled in GdkToolsConfiguration
    • pass in DAT as argument when starting android client for cloud
    • if DAT argument passed in, player pref is set
    • if no DAT argument exists / previously set as player pref - read from DAT.txt and save to player prefs

Tests

  • local launch works fine
  • android cloud launch via editor works fine
  • no DAT.txt generated unless specifically requested

Documentation

  • changelog
  • update screenshots/docs where relevant

Primary reviewers

If your change will take a long time to review, you can name at most two primary reviewers who are ultimately responsible for reviewing this request. @ mention them.

@improbable-prow-robot improbable-prow-robot added size/L Denotes a PR that changes 150-299 lines, ignoring generated files. A: core Area: Core GDK A: mobile Area: Mobile integration A: playground Area: Playground A: tooling Area: Tooling labels May 29, 2019
Signed-off-by: Paul Balaji <[email protected]>
@paulbalaji paulbalaji changed the title Move runtime IP / DevAuthToken to editorprefs Move runtime IP to EditorPref / DevAuthToken to PlayerPref May 31, 2019
Copy link
Contributor

@jessicafalk jessicafalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some smaller nits, but overall lgtm.
I assume you have tested that on an emulator and a phone

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
return false;
}

Debug.Log($"Saving token to Player Preferences.");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the log needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

given there's a couple ways of saving out a token (player prefs / .txt), I'd prefer to log where it's being saved

this way we'll be able to see if a user's actually created DAT.txt before complaining it doesn't exist

@paulbalaji paulbalaji merged commit 6ff6038 into develop Jun 3, 2019
@paulbalaji paulbalaji deleted the feature/move-some-config-to-prefs branch June 3, 2019 12:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A: core Area: Core GDK A: mobile Area: Mobile integration A: playground Area: Playground A: tooling Area: Tooling size/L Denotes a PR that changes 150-299 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants