This repository has been archived by the owner on Jan 18, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 77
Move runtime IP to EditorPref / DevAuthToken to PlayerPref #961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul Balaji <[email protected]>
…mand line/playerprefs where possible
improbable-prow-robot
added
size/L
Denotes a PR that changes 150-299 lines, ignoring generated files.
A: core
Area: Core GDK
A: mobile
Area: Mobile integration
A: playground
Area: Playground
A: tooling
Area: Tooling
labels
May 29, 2019
paulbalaji
commented
May 30, 2019
workers/unity/Packages/com.improbable.gdk.mobile/Editor/LaunchMenu.cs
Outdated
Show resolved
Hide resolved
Signed-off-by: Paul Balaji <[email protected]>
paulbalaji
commented
May 30, 2019
workers/unity/Packages/com.improbable.gdk.tools/DevAuthTokenUtils.cs
Outdated
Show resolved
Hide resolved
paulbalaji
changed the title
Move runtime IP / DevAuthToken to editorprefs
Move runtime IP to EditorPref / DevAuthToken to PlayerPref
May 31, 2019
jessicafalk
reviewed
May 31, 2019
workers/unity/Packages/com.improbable.gdk.core/Worker/WorkerConnector.cs
Outdated
Show resolved
Hide resolved
workers/unity/Packages/com.improbable.gdk.mobile/Editor/LaunchMenu.cs
Outdated
Show resolved
Hide resolved
workers/unity/Packages/com.improbable.gdk.tools/DevAuthTokenUtils.cs
Outdated
Show resolved
Hide resolved
workers/unity/Packages/com.improbable.gdk.tools/DevAuthTokenUtils.cs
Outdated
Show resolved
Hide resolved
workers/unity/Packages/com.improbable.gdk.tools/DevAuthTokenUtils.cs
Outdated
Show resolved
Hide resolved
workers/unity/Packages/com.improbable.gdk.tools/DevAuthTokenUtils.cs
Outdated
Show resolved
Hide resolved
workers/unity/Packages/com.improbable.gdk.tools/DevAuthTokenUtils.cs
Outdated
Show resolved
Hide resolved
workers/unity/Packages/com.improbable.gdk.tools/GdkToolsConfiguration.cs
Show resolved
Hide resolved
jessicafalk
approved these changes
May 31, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some smaller nits, but overall lgtm.
I assume you have tested that on an emulator and a phone
workers/unity/Packages/com.improbable.gdk.mobile/Editor/LaunchMenu.cs
Outdated
Show resolved
Hide resolved
workers/unity/Packages/com.improbable.gdk.tools/DevAuthTokenUtils.cs
Outdated
Show resolved
Hide resolved
zeroZshadow
approved these changes
May 31, 2019
workers/unity/Packages/com.improbable.gdk.tools/DevAuthTokenUtils.cs
Outdated
Show resolved
Hide resolved
return false; | ||
} | ||
|
||
Debug.Log($"Saving token to Player Preferences."); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the log needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
given there's a couple ways of saving out a token (player prefs / .txt), I'd prefer to log where it's being saved
this way we'll be able to see if a user's actually created DAT.txt before complaining it doesn't exist
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A: core
Area: Core GDK
A: mobile
Area: Mobile integration
A: playground
Area: Playground
A: tooling
Area: Tooling
size/L
Denotes a PR that changes 150-299 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tests
Documentation
Primary reviewers
If your change will take a long time to review, you can name at most two primary reviewers who are ultimately responsible for reviewing this request. @ mention them.