Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alternative way to add onboarding steps #34

Merged
merged 2 commits into from
Nov 1, 2023
Merged

Alternative way to add onboarding steps #34

merged 2 commits into from
Nov 1, 2023

Conversation

fedeisas
Copy link
Contributor

Maybe this could be useful to design each step on it's own class (extending OnboardingStep).

@fedeisas
Alternative way to add onboarding steps
504034d 
I think this could be useful to design each step on it's own class (extending OnboardingStep).
freekmurze
freekmurze requested changes Oct 31, 2023
View reviewed changes
src/OnboardingSteps.php Outdated Show resolved Hide resolved
@fedeisas fedeisas requested a review from freekmurze October 31, 2023 16:06
@freekmurze freekmurze merged commit 2e7e042 into spatie:main Nov 1, 2023
@freekmurze
Copy link
Member

Thanks!

@fedeisas fedeisas deleted the add_onboarding_step_method branch November 1, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freekmurze freekmurze Awaiting requested review from freekmurze

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fedeisas @freekmurze