Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update binding method #4

Merged
merged 1 commit into from
Jun 23, 2022
Merged

Update binding method #4

merged 1 commit into from
Jun 23, 2022

Conversation

tompec
Copy link
Contributor

@tompec tompec commented Jun 23, 2022

Registering the instance using the scoped methods causes the instance to be flushed when using a queue worker.

For example, the code User::find(1)->onboarding()->steps()->count() inside a queued job will always return return 0, even when onboarding steps exist.

This PR fixes that issue.

@freekmurze freekmurze requested a review from riasvdv June 23, 2022 14:01
@riasvdv riasvdv merged commit 3f82c27 into spatie:main Jun 23, 2022
@riasvdv
Copy link
Member

riasvdv commented Jun 23, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants