Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to output cache age header #385

Merged
merged 4 commits into from
May 16, 2022
Merged

Add option to output cache age header #385

merged 4 commits into from
May 16, 2022

Conversation

it-can
Copy link
Contributor

@it-can it-can commented May 14, 2022

I find it handy to have an cache age header in my responses. This option is disabled by default, and only works when the time-header is also active

freekmurze
freekmurze requested changes May 15, 2022
View reviewed changes
Copy link
Member

@freekmurze freekmurze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also update the readme?

src/Middlewares/CacheResponse.php Outdated Show resolved Hide resolved
@it-can
Copy link
Contributor Author

it-can commented May 15, 2022

Could you also update the readme?

done

@it-can it-can requested a review from freekmurze May 16, 2022 07:55
@freekmurze freekmurze merged commit aa44b99 into spatie:main May 16, 2022
@freekmurze
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freekmurze freekmurze Awaiting requested review from freekmurze

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@it-can @freekmurze