Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Add text labels to bare URLs #810

Merged
merged 7 commits into from
Jul 30, 2024
Merged

[Core] Add text labels to bare URLs #810

merged 7 commits into from
Jul 30, 2024

Conversation

bact
Copy link
Collaborator

@bact bact commented Jul 26, 2024 •
edited
Loading

Update refs in MediaType, packageVerificationCodeExcludedFile, ExternalRefType, HashAlgorithm

  • Add text labels to bare URLs, as they are required by OMG/ISO standard documents.
  • Add ref links to Bower, Maven, npm, NuGet packages. Using information from v2.3.
    • These links are already in Normative References chapter of the spec, but missing from v3.0 model file.
  • Standardized IETF RFC links -- see: What is a standard URL to reference IETF RFC? spdx-spec#1012
  • Update obsoleted spec documents:
    • sha224: replace pre-RFC (Internet Draft) ref with RFC 3874
    • sha256, sha384, sha51: replace obsoleted refs RFC 4634 with RFC 6234

This PR will also supersede small part of #751

@bact
Add text labels to bare links
8f0d273 
- sha224: replace pre-RFC (Internet Draft) ref to RFC 3874
- sha256, sha384, sha51: Replace obsoleted refs RFC 4634 with updated RFC 6234
- Standardized IETF RFC links

Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact
Copy link
Collaborator Author

bact commented Jul 26, 2024 •
edited
Loading

Waiting for a decision about standardized IETF RFC URLs in spdx/spdx-spec#1012

@bact bact mentioned this pull request Jul 26, 2024
Closed
@bact bact changed the title [Core] Add text labels to bare links [Core] Add text labels to bare URLs Jul 26, 2024
@bact bact mentioned this pull request Jul 26, 2024
Open
70 tasks
bact added 6 commits July 27, 2024 01:19
@bact
Add link to ISO 29147:2018
7e565fe 
Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact
Update RFC links
8cb25f4 
Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact
Add links and labels for package managers: bower, npm, nuget
450fc07 
Use info from https://spdx.github.io/spdx-spec/v2.3/external-repository-identifiers/#f3-package-manager

Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact
Add Maven ref
d57d47c 
Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact
Maven: package -> artifact
8da5594 
Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact
referece -> locator
5c29e16 
Use the term that use in ExternalRef's property name

Signed-off-by: Arthit Suriyawongkul <[email protected]>
goneall
goneall approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goneall goneall merged commit 14f36b4 into spdx:main Jul 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goneall goneall goneall approved these changes

@zvr zvr zvr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bact @zvr @goneall