-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Copyrights and licensing page #1010
Conversation
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please hold on merging this, I'm reviewing and discussing with the SC.
So it will not be published publicly yet. Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact Can we revise this as follows?
|
Merge copyrights.md into index.md Signed-off-by: Arthit Suriyawongkul <[email protected]> Co-Authored-By: Steve Winslow <[email protected]>
@swinslow Done. Everything is now in index.md. For Annex G and H, they are no longer the licenses. They are now read:
If you like, we can make the texts "Community Specification License 1.0" and "Creative Commons Attribution License 3.0 Unported" to be clickable and link to https://spdx.github.io/spdx-spec/v3.0/licenses/Community-Spec-1.0/ and https://spdx.github.io/spdx-spec/v3.0/licenses/CC-BY-3.0/ |
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Pending discussion between Bob, Steve & Mike. |
Hi @bact, On the linking to the license texts in GitHub, I don't have a particular preference here. Especially if it means having to keep track of version / branch numbers as the spec evolves, I'm fine with just the general reference since they're included as annexes in the spec anyway. As @kestewart mentioned, we had a few further edits based on discussions with OMG. Would you mind making a couple further update? Thank you again for all your help! = = = = =
= = = = = @bobmartin3000 @kestewart I'm suggesting that for the SPDX published version of the spec, we retain the "With thanks to..." section where it is. I understand that OMG may shift that to a different clause for their version. Please take a look and let me know if you have concerns about either of the changes above. Thanks! |
@swinslow added the new section as you suggested. I also added another heading "Contributors" so the list of contributors is separated from the "Use of Specification" If you think it may be not a good idea, please tell. thx |
LGTM - thanks Steve.
Get Outlook for iOS<https://aka.ms/o0ukef>
…________________________________
From: Steve Winslow ***@***.***>
Sent: Friday, August 9, 2024 3:52:10 PM
To: spdx/spdx-spec ***@***.***>
Cc: Robert A Martin ***@***.***>; Mention ***@***.***>
Subject: [EXT] Re: [spdx/spdx-spec] Add Copyrights and licensing page (PR #1010)
Hi @bact, On the linking to the license texts in GitHub, I don't have a particular preference here. Especially if it means having to keep track of version / branch numbers as the spec evolves, I'm fine with just the general reference since
Hi @bact<https://github.com/bact>,
On the linking to the license texts in GitHub, I don't have a particular preference here. Especially if it means having to keep track of version / branch numbers as the spec evolves, I'm fine with just the general reference since they're included as annexes in the spec anyway.
As @kestewart<https://github.com/kestewart> mentioned, we had a few further edits based on discussions with OMG. Would you mind making a couple further update? Thank you again for all your help!
= = = = =
1. On a new line immediately prior to "This work is licensed under the...", please add a heading that says "Use of Specification - Terms, Conditions & Notices"
2. After that paragraph, please add the following text:
Trademarks
SPDX® is a registered trademark of the Linux Foundation.
Compliance
Use of the SPDX trademarks is subject to the SPDX Trademark License, currently available at https://spdx.dev/about/legal-notices/
Software developed under the terms of the licenses under which this specification is issued may claim compliance or conformance with this specification if and only if the software provider complies with the SPDX Trademark License given above.
= = = = =
@bobmartin3000<https://github.com/bobmartin3000> @kestewart<https://github.com/kestewart> I'm suggesting that for the SPDX published version of the spec, we retain the "With thanks to..." section where it is. I understand that OMG may shift that to a different clause for their version.
Please take a look and let me know if you have concerns about either of the changes above. Thanks!
—
Reply to this email directly, view it on GitHub<#1010 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AUYBD7EYJ77US6JBBVAI5ATZQUMWVAVCNFSM6AAAAABLOOYCO2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENZYGY2DEOBWGM>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
@swinslow @bobmartin3000 @kestewart how are we supposed to use the name "Linux Foundation"?
|
@bact Good eye. :) The formal name of the LF is "The Linux Foundation". So for each of those, it should be a first-letter-capitalized "The" at front. Thanks for catching this! |
Thank you, I will change that accordingly. |
@bact One comment from your changes -- let's please not use the word "Contributors" for the heading there. That's because that word has particular meanings under the Community Spec license and I just want to avoid confusion around that (this relates also to the discussions we had with OMG yesterday). Agreed though with setting it off separately from the rest. Perhaps just "Thanks" as the heading? |
@swinslow got it. Will change the heading too |
Signed-off-by: Arthit Suriyawongkul <[email protected]>
@swinslow done. |
Per spdx#1010 (comment) Signed-off-by: Arthit Suriyawongkul <[email protected]>
Per spdx#1010 (comment) Signed-off-by: Arthit Suriyawongkul <[email protected]>
Per @swinslow comment at spdx#1010 (comment) Signed-off-by: Arthit Suriyawongkul <[email protected]>
Sorry @bact, I just realized one more tweak -- my apologies :) The heading "## Use of Specification - Terms, Conditions & Notices" on line 15 -- that should appear above "This work is licensed under..." on line 6. After that change, I think we can call this done! |
Signed-off-by: Arthit Suriyawongkul <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for handling all the adjustments, @bact. Greatly appreciate it!
Signed-off-by: Arthit Suriyawongkul <[email protected]>
@swinslow thank you for super quick review as well |
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Per @swinslow comment at #1010 (comment) Signed-off-by: Arthit Suriyawongkul <[email protected]>
Per #1010 (comment) Signed-off-by: Arthit Suriyawongkul <[email protected]>
Add new copyrights info to index.md
Using text from Bob's Word doc 2024-07-22