Fix support for node LTS versions #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: fix linting fix: dont use safe-buffer test: dont use deprecated asserts
daviddias
approved these changes
Nov 8, 2018
There was a problem hiding this comment.
❤️ Thank you @jacobheun for kicking ass and upgrading the whole spdy impl! :D
|
@jacobheun can you please update the package-lock.json with the new released versions of spdy-transport and handle-thing? |
jacobheun
force-pushed
the
chore/updates
branch
from
e888324 to
06385f5
Compare
|
@diasdavid package lock has been updated. I also dropped stable from Travis to focus on the LTS versions. Once spdy-http2/handle-thing#6 is resolved we can update Travis here as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in node 11.1.0
The build is currently breaking for node 11.1.0 as the params for
onStreamReadhave changed https://github.com/nodejs/node/blob/v11.1.0/lib/internal/stream_base_commons.js#L111. Thehandle-thingmodule will need to be updated to support that change.Depends on