Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add example of split API specifications with relative references #2009

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Add example of split API specifications with relative references #2009

merged 1 commit into from
Dec 4, 2024

Conversation

chrisinmtown
Copy link
Contributor

Store the API in one file, the schema definitions in another file

@chrisinmtown chrisinmtown mentioned this pull request Nov 28, 2024
Open
@chrisinmtown
Copy link
Contributor Author

chrisinmtown commented Nov 28, 2024 •
edited
Loading

Sorry for the comment churn. This example works with the latest commit on main branch. A few days ago a PR was merged that fixes a problem with split specs (see issues #1889, #1909) introduced in 3.0.3 and still present in released version 3.1.0. Took me a while to realize that!

@chrisinmtown chrisinmtown force-pushed the add-ex-rel-ref branch 2 times, most recently from cbc84da to 0cf24b2 Compare November 29, 2024 11:29
@chrisinmtown chrisinmtown changed the title Add example of using relative references in API specifications Add example of split API specifications with relative references Nov 29, 2024
@coveralls
Copy link

coveralls commented Nov 29, 2024 •
edited
Loading

Coverage Status

coverage: 94.408%. remained the same
when pulling 4a437b4 on chrisinmtown:add-ex-rel-ref
into 58c8bb6 on spec-first:main.

@chrisinmtown chrisinmtown marked this pull request as ready for review November 29, 2024 11:50
@chrisinmtown
Add example of split API specifications with relative references
4a437b4 
Store the API in one file, the schema definitions in another file
RobbeSneyders
RobbeSneyders approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@RobbeSneyders RobbeSneyders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @chrisinmtown!

Great to have an example of this.

@RobbeSneyders RobbeSneyders merged commit e5e20be into spec-first:main Dec 4, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobbeSneyders RobbeSneyders RobbeSneyders approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chrisinmtown @coveralls @RobbeSneyders