Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core/utils): transfer marked dependency to core/markdown #2240

Merged
merged 1 commit into from
Apr 9, 2019
Merged

refactor(core/utils): transfer marked dependency to core/markdown #2240

merged 1 commit into from
Apr 9, 2019

Conversation

saschanaz
Copy link
Collaborator

@saschanaz saschanaz commented Apr 9, 2019 •
edited
Loading

This is mainly to enable ES module system to load core/utils without requiring marked, and this anyway also looks more logical to me.

@saschanaz saschanaz requested a review from marcoscaceres April 9, 2019 02:20
marcoscaceres
marcoscaceres approved these changes Apr 9, 2019
View reviewed changes
Copy link
Contributor

@marcoscaceres marcoscaceres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to move stuff out of utils.

@saschanaz saschanaz merged commit 260c9e7 into develop Apr 9, 2019
@saschanaz saschanaz deleted the markdown-marked branch April 9, 2019 02:47
@saschanaz saschanaz mentioned this pull request Apr 9, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoscaceres marcoscaceres marcoscaceres approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saschanaz @marcoscaceres