refactor(tests): remove reliance on RequireJS #2306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoscaceres
force-pushed
the
remove_require
branch
from
5cad24e to
d4ac74f
Compare
marcoscaceres
commented
Apr 26, 2019
| @@ -62,22 +62,4 @@ describe("W3C — Conformance", () => { | |||
| const doc = await makeRSDoc(ops); | |||
| expect(doc.querySelectorAll("#conformance .rfc2119").length).toBe(0); | |||
| }); | |||
|
|
|||
| it("emits end event", async () => { | |||
There was a problem hiding this comment.
Don't really care for this as external events are deprecated.
|
I have figured out that |
|
Ok, let’s get this in now and then do the magic from #2233 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes MOST of the reliance on RequireJS. However, the worker script is still a problem because !text :( Will need to figure something out for that, but this gets us most of the way there.