Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): run tests in Safari also #2894

Draft
wants to merge 22 commits into
base: main
Choose a base branch
from
Draft

chore(ci): run tests in Safari also #2894

wants to merge 22 commits into from

Conversation

sidvishnoi
Copy link
Member

No description provided.

@sidvishnoi

This comment has been minimized.

Sign in to view
@sidvishnoi
Copy link
Member Author

Looks like karma-safari combo on GitHub action doesn't work well 😞

@sidvishnoi sidvishnoi added the Low priority Suggestions with no good driving force label May 22, 2020
@sidvishnoi
Copy link
Member Author

sidvishnoi commented Mar 18, 2021 •
edited
Loading

Safari tests are now working, but failing due to some reason. Using the fork until karma-runner/karma-safari-launcher#22 is merged and released.
@marcoscaceres Can you check if these tests actually fail in Safari?

@marcoscaceres
Copy link
Contributor

Interesting... there are some failures locally.

@sidvishnoi sidvishnoi removed the Low priority Suggestions with no good driving force label Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sidvishnoi @marcoscaceres