-
-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci/regressions): test respec-w3c differences across branches #3428
Conversation
f1c1b22
to
9c2c914
Compare
.github/workflows/regressions.yml
Outdated
- uses: actions/checkout@v2 | ||
- uses: actions/setup-node@v1 | ||
with: | ||
node-version: 12 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so olde?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using v12 everywhere else and I think spec-generator is on v12 also. So, should move all of them together. Breaking change?
Node v12 goes into EOL 2022-04-30 FWIW.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should be tied to LTS instead (everywhere)... 12 seems way too limiting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.github/workflows/regressions.yml
Outdated
- name: Install git-delta # prettier git diff | ||
run: | | ||
set -v | ||
wget -q -O delta.tar.gz https://github.com/dandavison/delta/releases/download/0.7.1/delta-0.7.1-x86_64-unknown-linux-gnu.tar.gz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wonder if this versioned software will become a problem to maintain? Probably not... just a thought.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking of converting it into a separate GitHub action, which I can update as needed.
cargo install
took ~4min, so had to use a pre-compiled binary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, but time taken on Ci shouldn't be an issue right? That's the "cost of doing business".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your meme game is strong, Padawan.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few little questions mostly... but looks good.
I'm a bit worried that we are following a moving target though... maybe we want a fake "kitchen sink" spec that tests a whole bunch of things... that might allow us to catch more errors in practice.
Do want to clarify that we'll run regression test on PR branches manually, when we feel like something in the spec might break.
Might be better to test the actual practice instead of trying to copy practice in kitchen sink test? |
Tradeoffs... happy to try this out for now and see how we go. |
This workflow finds the impact of changes in ReSpec on real-world specs. It's run on manual requests, to avoid wasting resources. It works as follows:
actions/upload-artifact
) .matrix.source
:before.html
.after.html
.A sample workflow run is available at https://github.com/w3c/respec/actions/runs/704622451 (corresponding to w3c@4aff5e7)